fix: fixed sheet visibility when handle provided null (#224)

gorhom · Jan 21, 2021 · c32e700 · c32e700
1 parent cbfe80a
commit c32e700
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/components/bottomSheet/BottomSheet.tsx b/src/components/bottomSheet/BottomSheet.tsx
@@ -124,8 +124,9 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
     // safe layout values
 
     const safeHandleHeight = useMemo(
-      () => handleHeight || DEFAULT_HANDLE_HEIGHT,
-      [handleHeight]
+      () =>
+        handleComponent === null ? 0 : handleHeight || DEFAULT_HANDLE_HEIGHT,
+      [handleHeight, handleComponent]
     );
     const safeContainerHeight = useMemo(
       () => _providedContainerHeight || containerHeight || WINDOW_HEIGHT,
@@ -139,7 +140,9 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
     );
     const shouldMeasureHandleHeight = useMemo(
       () =>
-        _providedHandleHeight === undefined && handleComponent !== undefined,
+        _providedHandleHeight === undefined &&
+        handleComponent !== undefined &&
+        handleComponent !== null,
       [_providedHandleHeight, handleComponent]
     );