Introduce Object Lifecycle Management #471

stephenplusplus · 2018-10-19T21:00:45Z

To Dos

Docs
System tests
Unit tests

This introduces one method, bucket.addLifecycleRule(rule, [options], [callback]):

Add a rule

bucket.addLifecycleRule({
  action: 'delete',
  condition: {
    age: 365 * 3 // Specified in days.
  }
});

Replace any existing rules

bucket.addLifecycleRule({
  action: 'delete',
  condition: {
    age: 365 * 3 // Specified in days.
  }
}, { append: false });

Remove any existing rules

bucket.setMetadata({ lifecycle: null });

JustinBeckwith

LGTM w/ nits

src/bucket.ts

+   * }, function(err, apiResponse) {});
+   */
+  addLifecycleRule(rule: LifecycleRule): Promise<SetBucketMetadataResponse>;
+  addLifecycleRule(


frankyn

Apologies on delay. Will perform another pass tomorrow morning. Overall I think it looks good so far.

I appreciate your patience!

src/bucket.ts

+   *   condition: {
+   *     createdBefore: new Date('2018')
+   *   },
+   *   storageClass: 'COLDLINE'


frankyn

Questions, comments and nits.

Thanks @stephenplusplus

src/bucket.ts

@@ -989,6 +1004,140 @@ class Bucket extends ServiceObject {
    this.getFilesStream = paginator.streamify('getFiles');
  }

+  /**
+   * Set the object lifecycle rules for objects in this bucket.


src/bucket.ts

@@ -79,6 +79,21 @@ interface WatchAllOptions {
  versions?: boolean;
 }

+/**
+ * @typedef {object} AddLifecycleRuleOptions Configuration options for Bucket#addLifecycleRule().
+ * @property {string} [append=true] The new rules will be appended to any


src/bucket.ts

+   *
+   * By default, the object lifecycle rule you provide to this method will be
+   * appended to any existing ones. To replace all existing rules, supply the
+   * `options` argument, setting `append` to `false`.


src/bucket.ts

+   * bucket.addLifecycleRule({
+   *   action: 'delete',
+   *   condition: {
+   *     matchesStorageClass: 'COLDLINE',


src/bucket.ts

+   *   lifecycleRules.forEach(lifecycleRule => {});
+   * });
+   *
+   * //-


src/bucket.ts

+   *
+   * @param {LifecycleRule} rule The new lifecycle rule to be added to objects
+   *     in this bucket.
+   * @param {string} [rule.storageClass] When using the `setStorageClass`


frankyn

Thanks, lgtm

src/bucket.ts

+   *
+   * @param {LifecycleRule} rule The new lifecycle rule to be added to objects
+   *     in this bucket.
+   * @param {string} [rule.storageClass] When using the `setStorageClass`


src/bucket.ts

@@ -79,6 +79,21 @@ interface WatchAllOptions {
  versions?: boolean;
 }

+/**
+ * @typedef {object} AddLifecycleRuleOptions Configuration options for Bucket#addLifecycleRule().
+ * @property {string} [append=true] The new rules will be appended to any


stephenplusplus · 2018-10-26T16:53:46Z

All tests have been written-- @callmehiphop want to take a quick look?

JustinBeckwith · 2018-10-31T17:29:25Z

@callmehiphop 👋 mind taking a look? @stephenplusplus it would be rad to get this released :)

stephenplusplus added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2018

stephenplusplus requested a review from frankyn October 19, 2018 21:00

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2018

ghost assigned stephenplusplus Oct 19, 2018

JustinBeckwith approved these changes Oct 20, 2018

View reviewed changes

ghost assigned JustinBeckwith Oct 20, 2018

stephenplusplus force-pushed the spp--lifecycle branch from 3e0ed0e to fea0bfe Compare October 22, 2018 16:14

frankyn suggested changes Oct 24, 2018

View reviewed changes

src/bucket.ts Outdated

* condition: {

* createdBefore: new Date('2018')

* },

* storageClass: 'COLDLINE'

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--lifecycle branch 2 times, most recently from 6005a30 to 6788426 Compare October 24, 2018 21:21

frankyn suggested changes Oct 24, 2018

View reviewed changes

stephenplusplus commented Oct 25, 2018

View reviewed changes

src/bucket.ts

* lifecycleRules.forEach(lifecycleRule => {});

* });

*

* //-

This comment was marked as spam.

Sign in to view

stephenplusplus commented Oct 25, 2018

View reviewed changes

src/bucket.ts

*

* @param {LifecycleRule} rule The new lifecycle rule to be added to objects

* in this bucket.

* @param {string} [rule.storageClass] When using the `setStorageClass`

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

frankyn approved these changes Oct 25, 2018

View reviewed changes

stephenplusplus force-pushed the spp--lifecycle branch from 60daec7 to 851b300 Compare October 26, 2018 16:23

stephenplusplus removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 26, 2018

stephenplusplus requested a review from callmehiphop October 26, 2018 16:53

stephenplusplus added 8 commits October 29, 2018 13:20

Introduce Object Lifecycle Management.

f9fdd57

Finish that sent

a340796

Make sample code more clear.

6aaaaa5

types fixed?

1832b01

lint

3a8defd

review feedback

1e69f4f

Unit test

ba946ff

overloading more better

c8c9b4c

stephenplusplus force-pushed the spp--lifecycle branch from 8f4f29c to c8c9b4c Compare October 29, 2018 17:27

callmehiphop approved these changes Oct 31, 2018

View reviewed changes

callmehiphop merged commit 69df77f into googleapis:master Oct 31, 2018

dependencies bot mentioned this pull request Nov 3, 2018

Update @google-cloud/storage in /packages/oc-gs-storage-adapter from 1.7.0 to 2.3.0 opencomponents/storage-adapters#121

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Object Lifecycle Management #471

Introduce Object Lifecycle Management #471

stephenplusplus commented Oct 19, 2018 •

edited

Loading

JustinBeckwith left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

frankyn left a comment

This comment was marked as spam.

frankyn left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

frankyn left a comment

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Oct 26, 2018

JustinBeckwith commented Oct 31, 2018

Introduce Object Lifecycle Management #471

Introduce Object Lifecycle Management #471

Conversation

stephenplusplus commented Oct 19, 2018 • edited Loading

To Dos

Add a rule

Replace any existing rules

Remove any existing rules

JustinBeckwith left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

frankyn left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

frankyn left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

frankyn left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Oct 26, 2018

JustinBeckwith commented Oct 31, 2018

stephenplusplus commented Oct 19, 2018 •

edited

Loading