-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add support for 'fields' query parameter to getFiles #2521
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e28ce5f
feature added
thiyaguk09 83de827
fix
thiyaguk09 828b645
Added system test and sample test cases
thiyaguk09 164975a
copyright fix
thiyaguk09 f6f8e48
Merge pull request #1 from thiyaguk09/#2138-feature-add-'fields'-to-g…
thiyaguk09 b466a7d
Merge branch 'main' of /~https://github.com/thiyaguk09/nodejs-storage-fork
thiyaguk09 41261d8
build: fix path-to-regexp to older version due to node 14 requirement
thiyaguk09 99e7acd
Merge pull request #2 from thiyaguk09/#2138-feature-add-'fields'-to-g…
thiyaguk09 65aaf97
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 5b1a681
Remove unnecessary sample code
thiyaguk09 af6adf9
Merge pull request #3 from thiyaguk09/#2138-feature-add-'fields'-to-g…
thiyaguk09 5336628
Merge branch 'main' of /~https://github.com/thiyaguk09/nodejs-storage-fork
thiyaguk09 e93bc98
Manually modify README regards remove unnecessary sample code
thiyaguk09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We adjusted the test placement to address the previous failures. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just add a tacking issue to remove this once we upgrade to Node 18 minimum so we don't forget.