Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isShutdown in HttpTransport #1901

Merged
merged 8 commits into from
Nov 27, 2023
Merged

feat: add isShutdown in HttpTransport #1901

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6438e7e
feat: add isShutdown in HttpTransport
JoeWang1127 Nov 22, 2023
5bb3ac3
fix lint
JoeWang1127 Nov 22, 2023
cfaeb93
add comment
JoeWang1127 Nov 22, 2023
6f39d67
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Nov 22, 2023
b71c6bc
refactor according to code review
JoeWang1127 Nov 22, 2023
1173150
restore comment changes
JoeWang1127 Nov 23, 2023
5adbcf8
change year
JoeWang1127 Nov 23, 2023
0f44569
change default implementation
JoeWang1127 Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
/**
* Thread-safe abstract HTTP transport.
*
* <p>Implementation is thread-safe, and sub-classes must be thread-safe. For maximum efficiency,
* <p>Implementation is thread-safe, and subclasses must be thread-safe. For maximum efficiency,
* applications should use a single globally-shared instance of the HTTP transport.
*
* <p>The recommended concrete implementation HTTP transport library to use depends on what
Expand Down Expand Up @@ -158,4 +158,14 @@ public boolean isMtls() {
* @since 1.4
*/
public void shutdown() throws IOException {}

/**
* Returns whether the transport is shutdown or not.
*
* @return true if the transport is shutdown.
* @since 1.44.0
*/
public boolean isShutdown() {
return true;
}
}