Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake)!: only compile protos if asked - storage #12481

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 26, 2023

Part of the work for #8022

This one is a bit weird. I think the protos should only be built with GCS+gRPC. (As opposed to, storage IN LISTS GOOGLE_CLOUD_CPP_ENABLE AND GOOGLE_CLOUD_CPP_ENABLE_GRPC)

Conditionally include the raw gRPC client in the throughput benchmark only if GCS+gRPC.


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal August 26, 2023 06:06 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (d000cf8) 93.62% compared to head (956be77) 93.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12481      +/-   ##
==========================================
- Coverage   93.62%   93.62%   -0.01%     
==========================================
  Files        2039     2039              
  Lines      180676   180677       +1     
==========================================
  Hits       169151   169151              
- Misses      11525    11526       +1     
Files Changed Coverage Δ
.../cloud/storage/benchmarks/throughput_experiment.cc 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc temporarily deployed to internal August 26, 2023 07:20 — with GitHub Actions Inactive
@dbolduc dbolduc temporarily deployed to internal August 28, 2023 00:11 — with GitHub Actions Inactive
@dbolduc dbolduc marked this pull request as ready for review August 28, 2023 01:02
@dbolduc dbolduc requested a review from a team as a code owner August 28, 2023 01:02
@dbolduc dbolduc merged commit cc50dd4 into googleapis:main Aug 28, 2023
@dbolduc dbolduc deleted the fix-8022-storage branch August 28, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants