Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake)!: only compile protos if asked - monitoring #12463

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 24, 2023

Part of the work for #8022 and #12428

Stop compiling monitoring_protos. Only compile them if monitoring is requested.

Use the common ga grpc library helper for monitoring. Note that we can do this because the protos have the right name.


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal August 24, 2023 23:50 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (af7e22c) 93.62% compared to head (243a66f) 93.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12463      +/-   ##
==========================================
- Coverage   93.62%   93.61%   -0.01%     
==========================================
  Files        2039     2039              
  Lines      180676   180676              
==========================================
- Hits       169153   169148       -5     
- Misses      11523    11528       +5     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 25, 2023 03:31
@dbolduc dbolduc requested a review from a team as a code owner August 25, 2023 03:31
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 05d5982 into googleapis:main Aug 25, 2023
@dbolduc dbolduc deleted the fix-8022-monitoring branch August 25, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants