cleanup(cmake): cleanups around library helper function #12431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
reviewed
Aug 21, 2023
| @@ -41,7 +41,7 @@ function (google_cloud_cpp_add_ga_grpc_library library display_name) | |||
| list(APPEND source_globs "${dir}*.h" "${dir}*.cc" "${dir}internal/*") | |||
| list(APPEND mocks_globs "${dir}mocks/*.h") | |||
| list(APPEND DOXYGEN_EXCLUDE_SYMBOLS "${library}_${ns}internal") | |||
| if (NOT dir STREQUAL "") | |||
| if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/${dir}samples") | |||
There was a problem hiding this comment.
FWIW, bigquery, iam and pubsublite also have this directory.
There was a problem hiding this comment.
Ack. Those are outside of the scope of #8022.
coryan
approved these changes
Aug 21, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #12431 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 2035 2035
Lines 180223 180223
=======================================
+ Hits 168736 168740 +4
+ Misses 11487 11483 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #12428
""outright. (This unblocks one of the dialogflows)NAMELINK_COMPONENT, as suggested by @coryan in review comments for refactor(cmake): add gRPC based library helper function #12429google_cloud_cpp_commonin the.pcfile whengoogle_cloud_cpp_grpc_utilsdepends ongoogle_cloud_cpp_commonThis change is