Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow HTTP POST for PATCH RPCs #1262

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix: Allow HTTP POST for PATCH RPCs #1262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b208e82
fix: Allow HTTP POST for PATCH RPCs
lqiu96 Mar 3, 2023
3488f20
chore: Add second handler for PATCH requests
lqiu96 Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions util/genrest/goviewcreator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,11 @@ func NewView(model *gomodel.Model) (*goview.View, error) {

for _, handler := range registered {
file.P(` router.HandleFunc(%q, rest.%s).Methods(%q)`, handler.pattern, handler.function, handler.verb)
// Java's PATCH requests are sent as POST requests with a `X-HTTP-Method-Override` header
if handler.verb == "PATCH" {
// HeadersRegexp is used to match for both POST Http Verb and the Header value
file.P(` router.HandleFunc(%q, rest.%s).HeadersRegexp("X-HTTP-Method-Override", "^PATCH$").Methods("POST")`, handler.pattern, handler.function)
}
}
file.P(` router.PathPrefix("/").HandlerFunc(rest.catchAllHandler)`)
file.P(`}`)
Expand Down