Simplify the ProvisionCallback API. #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](/~https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Every implementation needs access to the current `InternalContext` so we can save a bit of memory by just passing it. This is pretty minor since `ProvisionListeners` are rare, but it satisfies a long running TODO and allows us to eliminate some allocations from the normal provisioning path. PiperOrigin-RevId: 715467849
copybara-service
bot
force-pushed
the
test_712269258
branch
from
9842e3d to
325ac9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the ProvisionCallback API.
Every implementation needs access to the current
InternalContextso we can save a bit of memory by just passing it.This is pretty minor since
ProvisionListenersare rare, but it satisfies a long running TODO and allows us to eliminate some allocations from the normal provisioning path.