Skip to content

Commit

Permalink
Move protobuf_matchers and status_matchers to a testing package…
Browse files Browse the repository at this point in the history
… and remove the dependency from the `aggregators` package to the `executors` package.

PiperOrigin-RevId: 633375850
  • Loading branch information
michaelreneer authored and tensorflow-copybara committed May 14, 2024
1 parent 796738a commit 62fd042
Show file tree
Hide file tree
Showing 63 changed files with 178 additions and 167 deletions.
7 changes: 7 additions & 0 deletions tensorflow_federated/cc/core/impl/aggregation/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,10 @@ package(
default_applicable_licenses = ["//:package_license"],
default_visibility = ["//visibility:private"],
)

package_group(
name = "aggregation_packages",
packages = [
"//tensorflow_federated/cc/core/impl/aggregation/...",
],
)
32 changes: 16 additions & 16 deletions tensorflow_federated/cc/core/impl/aggregation/core/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:protobuf_matchers",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:protobuf_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -205,7 +205,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -217,7 +217,7 @@ cc_test(
":intrinsic",
"//tensorflow_federated/cc/common_libs:oss_test_main",
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand Down Expand Up @@ -260,7 +260,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -277,7 +277,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -303,7 +303,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -319,7 +319,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
"@com_google_absl//absl/types:span",
],
)
Expand All @@ -330,7 +330,7 @@ cc_test(
deps = [
":tensor",
"//tensorflow_federated/cc/common_libs:oss_test_main",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -341,7 +341,7 @@ cc_test(
":tensor",
":vector_string_data",
"//tensorflow_federated/cc/common_libs:oss_test_main",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -352,7 +352,7 @@ cc_test(
":mutable_string_data",
":tensor",
"//tensorflow_federated/cc/common_libs:oss_test_main",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
"@com_google_absl//absl/strings:string_view",
],
)
Expand All @@ -368,7 +368,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -385,7 +385,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -403,7 +403,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -419,7 +419,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)

Expand All @@ -437,7 +437,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
"@com_google_absl//absl/strings",
],
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_shape.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_shape.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_shape.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_spec.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_spec.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_spec.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_spec.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_spec.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_spec.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include "googletest/include/gtest/gtest.h"
#include "absl/strings/string_view.h"
#include "tensorflow_federated/cc/core/impl/aggregation/core/datatype.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#include "googlemock/include/gmock/gmock.h"
#include "googletest/include/gtest/gtest.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_shape.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/intrinsic.h"
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_aggregator.h"
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_aggregator_factory.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "googlemock/include/gmock/gmock.h"
#include "googletest/include/gtest/gtest.h"
#include "tensorflow_federated/cc/core/impl/aggregation/base/monitoring.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "googlemock/include/gmock/gmock.h"
#include "googletest/include/gtest/gtest.h"
#include "tensorflow_federated/cc/core/impl/aggregation/base/monitoring.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
#include "googlemock/include/gmock/gmock.h"
#include "googletest/include/gtest/gtest.h"
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_shape.h"
#include "tensorflow_federated/cc/core/impl/executors/protobuf_matchers.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/protobuf_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
#include "tensorflow_federated/cc/core/impl/aggregation/core/tensor_shape.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/protobuf_matchers.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/protobuf_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "googlemock/include/gmock/gmock.h"
#include "googletest/include/gtest/gtest.h"
#include "tensorflow_federated/cc/core/impl/aggregation/core/datatype.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
4 changes: 2 additions & 2 deletions tensorflow_federated/cc/core/impl/aggregation/protocol/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/testing:mocks",
"//tensorflow_federated/cc/core/impl/aggregation/testing:parse_text_proto",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/synchronization",
Expand Down Expand Up @@ -264,6 +264,6 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/testing",
"//tensorflow_federated/cc/core/impl/aggregation/testing:parse_text_proto",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
],
)
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/testing/mocks.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#include "tensorflow_federated/cc/core/impl/aggregation/protocol/configuration.pb.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated {
namespace aggregation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ cc_test(
":latency_aggregator",
"//tensorflow_federated/cc/common_libs:oss_test_main",
"//tensorflow_federated/cc/core/impl/aggregation/base",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
"@com_google_absl//absl/time",
],
)
Expand Down Expand Up @@ -115,8 +115,8 @@ cc_test(
"//tensorflow_federated/cc/core/impl/aggregation/testing:mocks",
"//tensorflow_federated/cc/core/impl/aggregation/testing:parse_text_proto",
"//tensorflow_federated/cc/core/impl/aggregation/testing:test_data",
"//tensorflow_federated/cc/core/impl/executors:protobuf_matchers",
"//tensorflow_federated/cc/core/impl/executors:status_matchers",
"//tensorflow_federated/cc/core/impl/testing:protobuf_matchers",
"//tensorflow_federated/cc/core/impl/testing:status_matchers",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings:cord",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include "googletest/include/gtest/gtest.h"
#include "absl/time/time.h"
#include "tensorflow_federated/cc/core/impl/aggregation/base/monitoring.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated::aggregation {
namespace {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
#include "tensorflow_federated/cc/core/impl/aggregation/testing/mocks.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/test_data.h"
#include "tensorflow_federated/cc/core/impl/aggregation/testing/testing.h"
#include "tensorflow_federated/cc/core/impl/executors/protobuf_matchers.h"
#include "tensorflow_federated/cc/core/impl/executors/status_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/protobuf_matchers.h"
#include "tensorflow_federated/cc/core/impl/testing/status_matchers.h"

namespace tensorflow_federated::aggregation {
namespace {
Expand Down
Loading

0 comments on commit 62fd042

Please sign in to comment.