Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORK IN PROGRESS: resource: Add preliminary EXIF support #4692

Closed
wants to merge 8 commits into from

Conversation

bep
Copy link
Member

@bep bep commented May 2, 2018

Fixes #4600

@bep bep force-pushed the exif branch 10 times, most recently from fe3c1e7 to 5d6c27d Compare May 8, 2018 17:37
@bep bep force-pushed the exif branch 8 times, most recently from 69bf398 to 39b6f87 Compare May 14, 2018 09:09
Enable with `imaging.hugo041ExperimentEnableExif = true`.

This commit  also make the Page.Data field into a method.

This is where we put resource-contextual data, such as `Exif` for images.

Having at as an map has some benefits in the templates, as you don't have to know what type of resource it is:

```bash
{{ with .Data.Exif }}Has Exif: {{ .Long }}{{ else }}No Exif for you.{{ end }}
```

The above can be used on any resource type, even pages.

Fixes gohugoio#4600
@stale
Copy link

stale bot commented Sep 17, 2018

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Sep 17, 2018
@bep bep added the Keep label Sep 17, 2018
@stale stale bot removed the Stale label Sep 17, 2018
@larrywright
Copy link

@bep Is this still waiting on a change to be merged upstream? I'm looking forward to this feature, so I'm happy to do testing or anything else that's needed to help move it along.

@bep
Copy link
Member Author

bep commented Feb 5, 2019

this still waiting on a change to be merged upstream?

Well, it is mostly waiting for me to get back to it.

@larrywright
Copy link

Is it something a relative newcomer to Hugo could pick up and help with? If there's something I can do, I'm happy to help. Otherwise I'll just wait patiently :)

@kmadel
Copy link

kmadel commented Mar 15, 2019

I would also like to see this added and am willing to help, what needs to be done still?

@HughP
Copy link

HughP commented Jul 10, 2019

@bep do you see any logical relationship between EXIF support and page resources which describe images in a bundle? for instance the discussion over at #4244.

@bep
Copy link
Member Author

bep commented Aug 31, 2019

Added in #6289

@bep bep closed this Aug 31, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EXIF metadata
4 participants