Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS and iOS export] Add localized application name to the translation .plist files. #58733

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 4, 2022

Note: in case of macOS, .app bundle file name should match non-localized name (which is true by default), if it's renamed, Finder will use file name.

Fixes #58709

@akien-mga akien-mga merged commit 12db0cd into godotengine:master Mar 4, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 4, 2022
@bruvzg bruvzg deleted the plist_locale branch March 4, 2022 09:54
@bruvzg
Copy link
Member Author

bruvzg commented Mar 4, 2022

There are some other strings, like microphone and camera usage descriptions, that can be translated in the .plist files. But these strings are in the export settings, and I'm not sure what is the best way to add translations for them.

Maybe it's better to move them to the project settings and translate by adding custom properties in the same way to the app name.

@akien-mga
Copy link
Member

akien-mga commented Mar 4, 2022

I think the way the app name is translated is actually somewhat hacky, it would be better to come up with a cleaner design for all this.

We could have a custom property editor control to edit multi-language strings so that one can easily add translations (similar to Dictionary editor I guess, but enforcing that the keys are valid language codes).

As for moving to project settings, I'm of two minds about it. Since they're platform specific and related to the export process, it makes most sense IMO to have them in the export preset. But if one wants to have multiple export presets for a given platform (e.g. full game and demo), it might be tedious not to have them shared... though at the same time some of those strings might need to be customized per-preset (like the name could have " Demo" added in the demo preset). Overall I think they're best in the preset, and the preset can be duplicated in the interface to create variants while sharing the base data like microphone and camera usage descriptions.

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation project name is not working for iOS export
2 participants