Complain if casting a freed object in a debug session #51094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, I guess @vnen should approve though. |
vnen
reviewed
Sep 13, 2021
|
Besides my question it looks good to me. |
The idea is to give the user a chance to realize a mistake that will cause a crash in a release build (or with no debugger attached).
RandomShaper
force-pushed
the
error_cast_freed_object
branch
from
426dc25 to
ddc7d7e
Compare
akien-mga
approved these changes
Sep 14, 2021
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to give the user a chance to realize a mistake that will cause a crash in a release build (or with no debugger attached).
Fixes #50968.
NOTE: The version for 3.x is #51095.