-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable mono editor build in CI #47600
Conversation
fb497ad
to
8bd537b
Compare
I tested artifacts and seems that editor works fine and can build project |
8bd537b
to
6384b56
Compare
56389ef
to
829fa76
Compare
ad34933
to
e1df1ed
Compare
148310e
to
6826f7e
Compare
I actually broke the Mono build yesterday, #53882 should fix it (at least the current error). Another proof that we need this finalized and merged :P |
6826f7e
to
c974cdc
Compare
I copied compilation instructions from 3.x branch and looks that now after producing binary, editor freeze when executing unit tests |
9d58368
to
e063f49
Compare
Looks that mono build is again broken
|
Fixed by #54016. |
e063f49
to
d1a95b5
Compare
Looks that there is another problem, because entire job freeze for 6 hours and fails - /~https://github.com/godotengine/godot/runs/3914980436?check_suite_focus=true
I tried to add |
d1a95b5
to
de11075
Compare
d1411bf
to
c33577d
Compare
<member name="mono/project/auto_update_project" type="bool" setter="" getter="" default="true"> | ||
</member> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update main.cpp
too:
// From editor/csharp_project.cpp.
GLOBAL_DEF("mono/project/auto_update_project", true);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should be done here?
I removed this line because i checked that auto_update_project
is not used in other files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove the dummy define from main.cpp
, it's no longer used.
c33577d
to
071829a
Compare
Thanks! |
Depends on #47414 which removes partial editor mono compilation instructions
It would allow to get from CI fully working Godot mono build exactly as in 3.2 branch