Fix no tween repeat after stop and restart (Fix #39801) #46310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmb462
changed the title
Calinou
added
bug
regression
topic:core
cherrypick:3.x
|
@jmb462 What happened to this PR? |
|
@KoBeWi OMG. I'm so stupid with git... |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tween was stopped, each interpolation in the list was set to active=false
then, the main active bool was set to false.
When starting the tween again, the main active bool was set to true but not each interpolation in the list : so no repeat was happening.
I've added a for loop to reactivate each interpolation in the interpolates list when start() is called.
Need to seek to 0.0 too because we don't want start() to act as resume().
Edit : Due to an huge git mistake, this PR has been closed and a new PR is open... Sorry for that.