Add make_local_canvas_position_global, the inverse to make_canvas_position_local

[Razzlegames]

Make a local canvas position transformed to global space.

• Just the inverse of Vector2 make_canvas_position_local(const Vector2 &screen_point) const;

Finally a follow up to #4854 , you know... 4 years later. :)

Test project: /~https://github.com/Razzlegames/GodotCanvasLocalToGlobalTest

[Razzlegames]

Made a test project. Please let me know if there's a formal test framework to add something to. Gut is looking pretty great, by the way: /~https://github.com/bitwes/Gut

[Calinou]

Made a test project. Please let me know if there's a formal test framework to add something to. Gut is looking pretty great, by the way: /~https://github.com/bitwes/Gut

We don't have built-in unit tests yet, but once #30743 is merged, there will be a way to write unit tests in C++ (which involve less moving parts than tests written in GDScript).

[realkotob]

I think the name of the function can be better, or at least it should follow the same naming pattern as the old function.

How about "make local position canvas"?

[Razzlegames]

Hmm that's better. Honestly both are clumsy.

I hate the original naming I choose, but I was trying to stick to the previous convention based on suggestions. I'd rather call both something like global_position_to_local and local_position_to_global or something.

[realkotob]

I prefer not to use local and global in this case, I think 'screen' and 'canvas' are better names since this code is specific to Canvas Item objects.

I think something like this would be best: make_canvas_position_to_screen_position and make_screen_position_to_canvas_position

or even better, convert_position_from_canvas_to_screen and convert_position_from_screen_to_canvas (instead of convert we can use change or even make).

[Razzlegames]

Hmm, but since it is called on a `Canvas` object, doesn't this make adding the word `canvas` redundant? Like for a `Vector2.normalized()` , it seems redundant to call it `Vector2.vector_normalized()`

…

On Tue, Mar 10, 2020 at 10:39 AM m Kotob ***@***.***> wrote: I prefer not to use local and global in this case, I think 'screen' and 'canvas' are better names since this code is specific to Canvas Item objects. I think something like this would be best: make_canvas_position_to_screen_position and make_screen_position_to_canvas_position — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36931?email_source=notifications&email_token=ACCZK7YE6N3LQDC4YTXB6OTRGZ3O3A5CNFSM4LEBLFK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMNT6Y#issuecomment-597219835>, or unsubscribe </~https://github.com/notifications/unsubscribe-auth/ACCZK74JLOIZOTNCQM557SDRGZ3O3ANCNFSM4LEBLFKQ> .

[Razzlegames]

Updated PR:

Ok what about make_local_canvas_position_global ? I think this follows the old naming: make_canvas_position_local

• The position is local (to a canvas), so local is an adjective in, local_canvas_position ,
• The position is in a CanvasItem so canvas is an adjective in local_canvas_position
• The end transformation is global (as apposed to local) so the make...global seems to make sense

Also it won't break the old API

[realkotob]

@Razzlegames The new names sound fine to me, it's to have redundant function names exposed instead of unclear ones.

Can potentially be improved but unless we find some existing naming convention to follow, this is probably the best we can think of for now.

[KoBeWi]

make_canvas_position_local() looks so obscure; I was not aware this method exists until now and I've been using equivalents (you just need get_viewport().canvas_transform to do the same). I guess if the original method exists, there is no reason not to have the opposite one, however the usefulness is questionable IMO.

Needs rebase and style fixes.

[KoBeWi]

Suggested change

	Transforms [code]local_point[/code] to a screen point.
	Basically the reverse of [code] make_canvas_position_local [/code]
	Transforms [code]local_point[/code] to a point in viewport's coordinate system.
	See also [method get_global_transform_with_canvas].