Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open selected folder when pressing the "Open" option in the menu #28807

Merged
merged 1 commit into from
May 11, 2019

Conversation

bojidar-bg
Copy link
Contributor

@bojidar-bg bojidar-bg commented May 10, 2019

An attempt to fix #28798. Probably incorrect, review with care.

@groud
Copy link
Member

groud commented May 10, 2019

I don't think this is the right solution, because every time you are going to update the tree, the path is going to be unfolded for no reason. I think the solution is to unfold the selected folders when using the "Open" option in the right click menu.

@bojidar-bg bojidar-bg force-pushed the 28798-open-filesystem branch from 59ed4b2 to fedf9cd Compare May 10, 2019 15:56
@bojidar-bg
Copy link
Contributor Author

Updated the PR, now it should be better.

@akien-mga akien-mga added this to the 3.2 milestone May 11, 2019
@akien-mga akien-mga requested a review from groud May 11, 2019 07:06
@groud
Copy link
Member

groud commented May 11, 2019

LGTM :)

@akien-mga akien-mga merged commit 89c37da into godotengine:master May 11, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open button in file system dock do nothing when folder is selected
3 participants