Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/email: Fix email stage serialization #13256

Merged
merged 14 commits into from
Feb 26, 2025
Merged

Conversation

melizeche
Copy link
Contributor

Details

Fixed a serialization error in the email stage that occurred when trying to pass Django model classes through Celery tasks. The error manifested as kombu.exceptions.EncodeError: Object of type ModelBase is not JSON serializable.

closes #13232


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@melizeche melizeche requested a review from a team as a code owner February 25, 2025 23:54
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ab1c1c9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67bf67d94a494b00084ccd41

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit ab1c1c9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67bf67d931592d000820508f
😎 Deploy Preview https://deploy-preview-13256--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (a22b558) to head (ab1c1c9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13256   +/-   ##
=======================================
  Coverage   92.70%   92.71%           
=======================================
  Files         792      793    +1     
  Lines       40234    40268   +34     
=======================================
+ Hits        37300    37334   +34     
  Misses       2934     2934           
Flag Coverage Δ
e2e 48.07% <13.15%> (-0.04%) ⬇️
integration 24.11% <2.63%> (-0.02%) ⬇️
unit 90.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ab1c1c9e059cee3c34e132767e8256669bbf7a4f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ab1c1c9e059cee3c34e132767e8256669bbf7a4f

Afterwards, run the upgrade commands from the latest release notes.

Copy link

@melizeche melizeche requested a review from BeryJu February 26, 2025 09:40
@rissson
Copy link
Member

rissson commented Feb 26, 2025

/cherry-pick version-2025.2

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@melizeche melizeche requested a review from rissson February 26, 2025 18:08
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson enabled auto-merge (squash) February 26, 2025 18:09
@rissson rissson merged commit 05cc64c into main Feb 26, 2025
85 checks passed
@rissson rissson deleted the fix/email-stage-serialization branch February 26, 2025 19:30
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 26, 2025
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
rissson pushed a commit that referenced this pull request Feb 26, 2025
)

Co-authored-by: Marcelo Elizeche Landó <marcelo@goauthentik.io>
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Fix email stage serialization (#13256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when send mail for password recover and user enroll
2 participants