-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mailer to use a queue #9789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a nit.
BTW, I was thinking of configuring my mail to use file persistance and suddenly realized that we will have a versioning problem if we recklessly change some struct in the future. I thought I should mention it.
Oh damn I forgot we need to actually change the message to use something that is serialisable. |
I need to add I.e.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked again, because of the recent changes. It passes test
and test-sqlite
on my dev env and seems to work alright.
Codecov Report
@@ Coverage Diff @@
## master #9789 +/- ##
==========================================
+ Coverage 42.18% 42.21% +0.03%
==========================================
Files 603 603
Lines 78884 78885 +1
==========================================
+ Hits 33275 33301 +26
+ Misses 41531 41506 -25
Partials 4078 4078
Continue to review full report at Codecov.
|
Move the mailer to use the generalised queue format.
This is a breakout from #8874