Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Style tweaks to issue selection #6196

Merged
merged 3 commits into from
Feb 27, 2019
Merged

UI: Style tweaks to issue selection #6196

merged 3 commits into from
Feb 27, 2019

Conversation

silverwind
Copy link
Member

  • Prevent jump in layout when selecting the first issue
  • Remove useless padding on top of first issue

screenshot 2019-02-26 at 22 53 30

@silverwind
UI: Style tweaks to issue selection
7068e39 
- Prevent jump in layout when selecting the first issue
- Remove useless padding on top of first issue
silverwind
silverwind commented Feb 26, 2019
View reviewed changes
public/less/_repository.less
#issue-actions {
margin-top: -1rem !important; // counteract padding from Semantic
}

Copy link
Member Author

@silverwind silverwind Feb 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra margin comes from Semantic's .ui .grid + .grid. I was not able to overrule their rule with a margin-top: 0 for some reason, so I went with this instead.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2019
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 26, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 26, 2019
@codecov-io
Copy link

codecov-io commented Feb 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a121497). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6196   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      354           
  Lines             ?    50192           
  Branches          ?        0           
=========================================
  Hits              ?    19510           
  Misses            ?    27857           
  Partials          ?     2825

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a121497...43b4fcb. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2019
@zeripath zeripath merged commit b1ffe7e into go-gitea:master Feb 27, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hexfs hexfs hexfs approved these changes

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @codecov-io @techknowlogick @lafriks @hexfs @zeripath @GiteaBot