Fix bug when read public repo lfs file (#5912)

* fix bug when read public repo lfs file * add comment on lfs permission check
go-gitea · Jan 31, 2019 · bbad9b6 · bbad9b6
1 parent 0823791
commit bbad9b6
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/modules/lfs/server.go b/modules/lfs/server.go
@@ -497,12 +497,15 @@ func authenticate(ctx *context.Context, repository *models.Repository, authoriza
 		accessMode = models.AccessModeWrite
 	}
 
+	// ctx.IsSigned is unnecessary here, this will be checked in perm.CanAccess
 	perm, err := models.GetUserRepoPermission(repository, ctx.User)
 	if err != nil {
 		return false
 	}
-	if ctx.IsSigned {
-		return perm.CanAccess(accessMode, models.UnitTypeCode)
+
+	canRead := perm.CanAccess(accessMode, models.UnitTypeCode)
+	if canRead {
+		return true
 	}
 
 	user, repo, opStr, err := parseToken(authorization)