-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS Provider for GoDaddy #416
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b2ec03b
Support for DNS Provider: godaddy
smerschjohann 54329cf
GoDaddy DNS provider PUTs list instead of PATCH
sjawhar 8f84e3d
Merge branch 'master' into godaddy
xenolf ec360bc
Merge branch 'master' into godaddy
xenolf 2d34bce
Merge branch 'master' into godaddy
xenolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,155 @@ | ||
// Package godaddy implements a DNS provider for solving the DNS-01 challenge using godaddy DNS. | ||
package godaddy | ||
|
||
import ( | ||
"fmt" | ||
"io" | ||
"net/http" | ||
"os" | ||
"time" | ||
|
||
"bytes" | ||
"encoding/json" | ||
"github.com/xenolf/lego/acme" | ||
"io/ioutil" | ||
"strings" | ||
) | ||
|
||
// GoDaddyAPIURL represents the API endpoint to call. | ||
const apiURL = "https://api.godaddy.com" | ||
|
||
// DNSProvider is an implementation of the acme.ChallengeProvider interface | ||
type DNSProvider struct { | ||
apiKey string | ||
apiSecret string | ||
} | ||
|
||
// NewDNSProvider returns a DNSProvider instance configured for godaddy. | ||
// Credentials must be passed in the environment variables: GODADDY_API_KEY | ||
// and GODADDY_API_SECRET. | ||
func NewDNSProvider() (*DNSProvider, error) { | ||
apikey := os.Getenv("GODADDY_API_KEY") | ||
secret := os.Getenv("GODADDY_API_SECRET") | ||
return NewDNSProviderCredentials(apikey, secret) | ||
} | ||
|
||
// NewDNSProviderCredentials uses the supplied credentials to return a | ||
// DNSProvider instance configured for godaddy. | ||
func NewDNSProviderCredentials(apiKey, apiSecret string) (*DNSProvider, error) { | ||
if apiKey == "" || apiSecret == "" { | ||
return nil, fmt.Errorf("GoDaddy credentials missing") | ||
} | ||
|
||
return &DNSProvider{apiKey, apiSecret}, nil | ||
} | ||
|
||
// Timeout returns the timeout and interval to use when checking for DNS | ||
// propagation. Adjusting here to cope with spikes in propagation times. | ||
func (c *DNSProvider) Timeout() (timeout, interval time.Duration) { | ||
return 120 * time.Second, 2 * time.Second | ||
} | ||
|
||
func (c *DNSProvider) extractRecordName(fqdn, domain string) string { | ||
name := acme.UnFqdn(fqdn) | ||
if idx := strings.Index(name, "."+domain); idx != -1 { | ||
return name[:idx] | ||
} | ||
return name | ||
} | ||
|
||
// Present creates a TXT record to fulfil the dns-01 challenge | ||
func (c *DNSProvider) Present(domain, token, keyAuth string) error { | ||
fqdn, value, ttl := acme.DNS01Record(domain, keyAuth) | ||
domainZone, err := c.getZone(fqdn) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if ttl < 600 { | ||
ttl = 600 | ||
} | ||
|
||
recordName := c.extractRecordName(fqdn, domainZone) | ||
rec := []DNSRecord{ | ||
{ | ||
Type: "TXT", | ||
Name: recordName, | ||
Data: value, | ||
Ttl: ttl, | ||
}, | ||
} | ||
|
||
return c.updateRecords(rec, domainZone, recordName) | ||
} | ||
|
||
func (c *DNSProvider) updateRecords(records []DNSRecord, domainZone string, recordName string) error { | ||
body, err := json.Marshal(records) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
var resp *http.Response | ||
resp, err = c.makeRequest("PUT", fmt.Sprintf("/v1/domains/%s/records/TXT/%s", domainZone, recordName), bytes.NewReader(body)) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
defer resp.Body.Close() | ||
|
||
if resp.StatusCode != http.StatusOK { | ||
bodyBytes, _ := ioutil.ReadAll(resp.Body) | ||
return fmt.Errorf("Could not create record %v; Status: %v; Body: %s\n", string(body), resp.StatusCode, string(bodyBytes)) | ||
} | ||
return nil | ||
} | ||
|
||
// CleanUp sets null value in the TXT DNS record as GoDaddy has no proper DELETE record method | ||
func (c *DNSProvider) CleanUp(domain, token, keyAuth string) error { | ||
fqdn, _, _ := acme.DNS01Record(domain, keyAuth) | ||
domainZone, err := c.getZone(fqdn) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
recordName := c.extractRecordName(fqdn, domainZone) | ||
rec := []DNSRecord{ | ||
{ | ||
Type: "TXT", | ||
Name: recordName, | ||
Data: "null", | ||
}, | ||
} | ||
|
||
return c.updateRecords(rec, domainZone, recordName) | ||
} | ||
|
||
func (c *DNSProvider) getZone(fqdn string) (string, error) { | ||
authZone, err := acme.FindZoneByFqdn(fqdn, acme.RecursiveNameservers) | ||
if err != nil { | ||
return "", err | ||
} | ||
|
||
return acme.UnFqdn(authZone), nil | ||
} | ||
|
||
func (c *DNSProvider) makeRequest(method, uri string, body io.Reader) (*http.Response, error) { | ||
req, err := http.NewRequest(method, fmt.Sprintf("%s%s", apiURL, uri), body) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
req.Header.Set("Accept", "application/json") | ||
req.Header.Set("Content-Type", "application/json") | ||
req.Header.Set("Authorization", fmt.Sprintf("sso-key %s:%s", c.apiKey, c.apiSecret)) | ||
|
||
client := http.Client{Timeout: 30 * time.Second} | ||
return client.Do(req) | ||
} | ||
|
||
type DNSRecord struct { | ||
Type string `json:"type"` | ||
Name string `json:"name"` | ||
Data string `json:"data"` | ||
Priority int `json:"priority,omitempty"` | ||
Ttl int `json:"ttl,omitempty"` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
package godaddy | ||
|
||
import ( | ||
"os" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
var ( | ||
godaddyAPIKey string | ||
godaddyAPISecret string | ||
godaddyDomain string | ||
godaddyLiveTest bool | ||
) | ||
|
||
func init() { | ||
godaddyAPIKey = os.Getenv("GODADDY_API_KEY") | ||
godaddyAPISecret = os.Getenv("GODADDY_API_SECRET") | ||
godaddyDomain = os.Getenv("GODADDY_DOMAIN") | ||
|
||
if len(godaddyAPIKey) > 0 && len(godaddyAPISecret) > 0 && len(godaddyDomain) > 0 { | ||
godaddyLiveTest = true | ||
} | ||
} | ||
|
||
func TestNewDNSProvider(t *testing.T) { | ||
provider, err := NewDNSProvider() | ||
|
||
if !godaddyLiveTest { | ||
assert.Error(t, err) | ||
} else { | ||
assert.NotNil(t, provider) | ||
assert.NoError(t, err) | ||
} | ||
} | ||
|
||
func TestDNSProvider_Present(t *testing.T) { | ||
if !godaddyLiveTest { | ||
t.Skip("skipping live test") | ||
} | ||
|
||
provider, err := NewDNSProvider() | ||
assert.NoError(t, err) | ||
|
||
err = provider.Present(godaddyDomain, "", "123d==") | ||
assert.NoError(t, err) | ||
} | ||
|
||
func TestDNSProvider_CleanUp(t *testing.T) { | ||
if !godaddyLiveTest { | ||
t.Skip("skipping live test") | ||
} | ||
|
||
provider, err := NewDNSProvider() | ||
assert.NoError(t, err) | ||
|
||
err = provider.CleanUp(godaddyDomain, "", "123d==") | ||
assert.NoError(t, err) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this check? I'm new to lego, but I don't see it in the other provider modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GoDaddy does not allow ttls lower than 600. Therefore i set it to its minimum.