Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSUB-1013] Fix typo & create eraOption #172

Merged
merged 3 commits into from
Jan 21, 2024
Merged

[CSUB-1013] Fix typo & create eraOption #172

merged 3 commits into from
Jan 21, 2024

Conversation

pLabarta
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

atodorov
atodorov requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 warnings from eslint, otherwise looks good to me.

cli/src/commands/staking/distribute.ts Show resolved Hide resolved
@pLabarta pLabarta force-pushed the 1013-cli-small-fixes branch from 9b344b1 to dc1ab99 Compare January 21, 2024 22:42
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

@pLabarta pLabarta merged commit ccd5c8f into dev Jan 21, 2024
30 checks passed
@pLabarta pLabarta deleted the 1013-cli-small-fixes branch January 21, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@atodorov atodorov atodorov approved these changes

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@frankli-dev frankli-dev Awaiting requested review from frankli-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pLabarta @atodorov @nathanwhit