Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore.exhange rates api test #6395

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jan 16, 2025

AB#32744

Describe your changes

  • Call exchange rate cronjob via endpoint
  • Exchange rate mock -service
  • Exchange rate api service

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@RubenGeo RubenGeo added the chore Something that does not affect the end user label Jan 16, 2025
@Copilot Copilot bot review requested due to automatic review settings January 16, 2025 13:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • services/121-service/swagger.json: Language not supported
  • services/121-service/module-dependencies.md: Evaluated as low risk
  • services/121-service/src/cronjob/cronjob.module.ts: Evaluated as low risk
  • services/121-service/src/cronjob/cronjob.service.ts: Evaluated as low risk
  • services/121-service/src/exchange-rates/dtos/get-exchange-rate.dto.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

services/121-service/src/exchange-rates/exchange-rates.service.ts:27

  • Ensure that the getAndStoreProgramsExchangeRates method is covered by tests, as it is a critical part of the functionality.
public async getAndStoreProgramsExchangeRates(): Promise<void> {
@PeterSmallenbroek PeterSmallenbroek merged commit ba2cf16 into main Jan 17, 2025
8 checks passed
@PeterSmallenbroek PeterSmallenbroek deleted the chore.exhange-rates-api-test branch January 17, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants