Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert jumbo quick fix + update fspconfigs FKs to NULL AB#32373 #6351

Merged

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Jan 3, 2025

AB#32373

Describe your changes

Correct jumbo quick fix

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@RubenGeo
Copy link
Contributor

RubenGeo commented Jan 6, 2025

I all looks good. Did you test it with a production dump, do you think it is needed? @jannisvisser

@jannisvisser
Copy link
Contributor Author

@RubenGeo yes, see notes in task (which you have already seen by now I see)

@RubenGeo RubenGeo merged commit 0ff50a0 into fix.program-fsp-config-nullable-FK Jan 6, 2025
6 checks passed
@RubenGeo RubenGeo deleted the fix.jumbo-correct-quick-fix branch January 6, 2025 08:24
jannisvisser added a commit that referenced this pull request Jan 6, 2025
…6351)

* fix: revert jumbo quick fix + update fspconfigs FKs to NULL AB#32373

* fix: remove jumbo fspconfig AB#32373
RubenGeo pushed a commit that referenced this pull request Jan 8, 2025
…6351)

* fix: revert jumbo quick fix + update fspconfigs FKs to NULL AB#32373

* fix: remove jumbo fspconfig AB#32373
RubenGeo pushed a commit that referenced this pull request Jan 9, 2025
…6351)

* fix: revert jumbo quick fix + update fspconfigs FKs to NULL AB#32373

* fix: remove jumbo fspconfig AB#32373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants