Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api tests for update contact info #6331

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Dec 23, 2024

AB#32342

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Copilot Copilot bot review requested due to automatic review settings December 23, 2024 07:21
@RubenGeo RubenGeo added the chore Something that does not affect the end user label Dec 23, 2024
@RubenGeo RubenGeo force-pushed the bug.update-visa-customer-after-switch branch from c2fa471 to 8378662 Compare December 23, 2024 07:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

services/mock-service/src/fsp-integration/intersolve-visa/intersolve-visa.mock.service.ts:602

  • [nitpick] The error message 'The field value is required.' is unclear. It should specify which field is missing or invalid.
description: 'The field value is required.',

Ruben added 2 commits January 3, 2025 12:50
@jannisvisser jannisvisser force-pushed the bug.update-visa-customer-after-switch branch from 2bcee96 to 2e448bc Compare January 3, 2025 11:50
@RubenGeo RubenGeo merged commit 277d2b0 into main Jan 3, 2025
7 checks passed
@RubenGeo RubenGeo deleted the bug.update-visa-customer-after-switch branch January 3, 2025 12:02
Piotrk39 pushed a commit that referenced this pull request Jan 9, 2025
Signed-off-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: Ruben <vandervalk@geoit.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants