Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump applicationinsights from 2.9.6 to 3.4.0 in /services/121-service #6076

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/test_pull_request_formatting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,17 @@ jobs:
core.endGroup()

const prDescription = pr.data.body;
if (!/AB#\d{5}/.test(prDescription)) {
const prLabels = pr.data.labels.map(label => label.name);

if (prLabels.includes('dependencies')) {
core.notice('✅ PR contains a "dependencies" label. Do not check on AB#XXXX.');
} else if (!/AB#\d{5}/.test(prDescription)) {
core.setFailed('Please make sure you have replaced AB#XXXX with a valid DevOps ID in your PR description');
} else {
core.notice('✅ PR description contains a DevOps ID');
}

const validLabels = ['enhancement', 'bugfix', 'dependencies', 'chore', 'ignore-for-release', 'portalicious', 'other'];
const prLabels = pr.data.labels.map(label => label.name);
if (!prLabels.some(label => validLabels.includes(label))) {
core.setFailed('Add one of the following labels to your PR: enhancement, bugfix, chore, ignore-for-release, portalicious, other');
} else {
Expand Down
Loading
Loading