paymentCountRemaining should be non-editable (#6363)

* paymentCountRemaining should be non-editable * linting
global-121 · Jan 9, 2025 · 505f1ea · 505f1ea
1 parent 88283eb
commit 505f1ea
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/interfaces/Portalicious/src/app/domains/project/project-attribute.helpers.ts b/interfaces/Portalicious/src/app/domains/project/project-attribute.helpers.ts
@@ -21,6 +21,7 @@ export const ATTRIBUTE_EDIT_INFO: Partial<
   Record<GenericRegistrationAttributes, string>
 > = {
   maxPayments: $localize`:@@attribute-edit-info-maxPayments:The maximum number of payments for this Person Affected. You can remove the limit by removing the value and saving.`,
+  paymentCountRemaining: $localize`:@@attribute-edit-info-paymentCountRemaining:This is automatically calculated based on Max. payments and payments sucessfully sent`,
   paymentAmountMultiplier: $localize`:@@attribute-edit-info-paymentAmountMultiplier:The transfer value will be multiplied by this number for this Person Affected`,
   phoneNumber: $localize`:@@attribute-edit-info-phoneNumber:The required format is: ONLY numbers, including country-code.`,
   scope: $localize`:@@attribute-edit-info-scope:Separate the parts with a dot (i.e. 'amsterdam.west').`,

diff --git a/interfaces/Portalicious/src/app/services/registration-attribute.service.ts b/interfaces/Portalicious/src/app/services/registration-attribute.service.ts
@@ -34,7 +34,11 @@ import { Registration } from '~/domains/registration/registration.model';
 import { AuthService } from '~/services/auth.service';
 import { TranslatableStringService } from '~/services/translatable-string.service';
 
-const nonEditableAttributes = ['inclusionScore', 'name'];
+const nonEditableAttributes = [
+  'inclusionScore',
+  'name',
+  'paymentCountRemaining',
+];
 
 const getGenericAttributeType = (
   attributeName: GenericRegistrationAttributes,

diff --git a/interfaces/Portalicious/src/locale/messages.nl.xlf b/interfaces/Portalicious/src/locale/messages.nl.xlf
@@ -1808,6 +1808,10 @@
         <source>Changes that you made may not be saved. Are you sure you wish to proceed?</source>
         <target state="new">Changes that you made may not be saved. Are you sure you wish to proceed?</target>
       </trans-unit>
+      <trans-unit id="attribute-edit-info-paymentCountRemaining" datatype="html">
+        <source>This is automatically calculated based on Max. payments and payments sucessfully sent</source>
+        <target state="new">This is automatically calculated based on Max. payments and payments sucessfully sent</target>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/interfaces/Portalicious/src/locale/messages.xlf b/interfaces/Portalicious/src/locale/messages.xlf
@@ -1358,6 +1358,9 @@
       <trans-unit id="8602877633844729884" datatype="html">
         <source>Changes that you made may not be saved. Are you sure you wish to proceed?</source>
       </trans-unit>
+      <trans-unit id="attribute-edit-info-paymentCountRemaining" datatype="html">
+        <source>This is automatically calculated based on Max. payments and payments sucessfully sent</source>
+      </trans-unit>
     </body>
   </file>
 </xliff>