fix(MapWindow): unicode foes in read_into_memory() used by gitpython TCs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Byron please delay the release, to include this fix (and maching code from gitpython project). |
|
Changes Unknown when pulling 1bb6ff0 on ankostis:win_mmap into * on gitpython-developers:master*. |
|
Changes Unknown when pulling 91814e6 on ankostis:win_mmap into * on gitpython-developers:master*. |
1 similar comment
|
Changes Unknown when pulling 91814e6 on ankostis:win_mmap into * on gitpython-developers:master*. |
|
But is not ready yet... |
Drop Windows only codepath bypassing memory-mapping due to some leaks in the past. Now Appveyor proves everything run ok. Additionally, this codepath had unicode problems on PY3. So deleting it, fixes 2 TCs in gitpython: + TestRepo.test_file_handle_leaks() + TestObjDbPerformance.test_random_access() See gitpython-developers/GitPython#525
|
Changes Unknown when pulling b2eafcc on ankostis:win_mmap into * on gitpython-developers:master*. |
ankostis
added a commit
to ankostis/GitPython
that referenced
this pull request
Oct 22, 2016
Now 2 more TCs pass in Windows: + TestRepo.test_file_handle_leaks() + TestObjDbPerformance.test_random_access() See gitpython-developers/smmap#30
|
It is ok now. |
|
Looks good! Thank you. |
|
Released via v2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Windows only codepath bypassing memory-mapping due to some leaks in
the past.
Now Appveyor proves everything run ok.
Additionally, this codepath had unicode problems on PY3. So deleting it,
fixes 2 TCs in gitpython:
See gitpython-developers/GitPython#525