Rust: give more options for building in README.md
#18468
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
paldepind
requested changes
Jan 17, 2025
| @@ -40,4 +48,17 @@ TODO | |||
|
|
|||
| ### Code Generation | |||
|
|
|||
| TODO | |||
| If you do changes to either | |||
There was a problem hiding this comment.
Suggested change
| If you do changes to either | |
| If you make changes to either |
| @@ -40,4 +48,17 @@ TODO | |||
|
|
|||
| ### Code Generation | |||
|
|
|||
| TODO | |||
| If you do changes to either | |||
| * `ast-generator`, or | |||
There was a problem hiding this comment.
Perhaps this will make it a bit clearer that it's talking about a directory?
Suggested change
| * `ast-generator`, or | |
| * `ast-generator/`, or |
| * `schema/*.py` | ||
|
|
||
| you'll need to regenerate code. You can do so running | ||
| ```bash |
There was a problem hiding this comment.
Mega nitpick, but I think it's cleaner to use sh for things that works in any shell and not just Bash.
Suggested change
| ```bash | |
| ```sh |
| ``` | ||
|
|
||
| Sometimes, especially if resolving conflicts on generated files, you might need to run | ||
| ```bash |
There was a problem hiding this comment.
Suggested change
| ```bash | |
| ```sh |
|
|
||
| Sometimes, especially if resolving conflicts on generated files, you might need to run | ||
| ```bash | ||
| bazel run @codeql//rust/codegen -- --force |
There was a problem hiding this comment.
Really great to have this documented 👍. I struggled with that until I found the --force flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.