Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and make the annotation schema more uniform. #763

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Conversation

manthey
Copy link
Member

@manthey manthey commented Jan 24, 2022

Resolves #762.

@manthey manthey requested a review from naglepuff January 24, 2022 20:56
@naglepuff
Copy link
Collaborator

I'm having some trouble with these changes. Here's an annotation that works (can be successfully uploaded) in master but not in adjust-schema:

{
	"name": "overlay_test",
	"description": "",
	"elements": [
		{
			"type": "imageoverlay",
			"girderId": "61b243b9b9de8887df5cd186",
			"opacity": 0.5,
			"group": "myGroup"	
		}
	]
}

In this case its the group property that appears to be the cause of failure. This seems to be the case for label, user, and id.

The use of AllOf makes for a long complicated schema.  By merging
dictionaries instead, the schema is shorter and clearer.
@manthey manthey merged commit b8b6b4f into master Jan 25, 2022
@manthey manthey deleted the adjust-schema branch January 25, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow image overlay schema to contain additional properties such as ID
2 participants