Add additional behaviors to image overlays #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendering image overlay element annotations, use the global opacity to help set the initial opactity. Also make image overlay layers respond to changes in the global opacity.
This supports deleting individual elements from an annotation containing overlay elements (e.g. from the HistomicsUI edit annotation widget.
If re-drawing an annotation with image overlay elements, compare the updated results of `annotation.overlays()` to the overlays stored in `this._annotations`. This captures changes to the `annotation._elements` collection between the initial render of the annotation and the redraw.
manthey
reviewed
Jan 24, 2022
| @@ -508,7 +508,7 @@ class AnnotationSchema: | |||
| 'group': groupSchema, | |||
| }, | |||
| 'required': ['girderId', 'type'], | |||
| 'additionalProperties': False, | |||
| 'additionalProperties': True, | |||
There was a problem hiding this comment.
Probably the correct thing to do is to make the overlay annotation inherit from the baseShapeSchema, except that we don't want to get the line and lineWidth properties. We can do this in a separate PR -- baseShapeSchema would inherit from baseElementSchema which would exclude those properties and then the overlay annotation would inherit from that.
manthey
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rounds out some functionality for image overlays that make them more reactive in applications like HistomicsUI.
Specifically, this PR introduces the following changes:
globalAnnotationOpacityof the image viewer. As a result, image overlays now change opacity based on the slider in HistomicsUI.idproperty would be added to the overlay elements.drawAnnotationhas been updated to account for the case where an image overlay element was removed from the annotation between an initial call todrawAnnotationand a follow up call todrawAnnotation.