-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the msvc failure on json config #1610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! An alternative (for small files) would be creating a temporary file in the working directory and deleting it afterwards. For the large matrices, it is sensible to store them separately, but for just JSON input, we could do it inline
I thought the same thing, too. but I also think we can use the filesystem to replace the path when we move to c++17. |
@yhmtsai
so I think we better avoid it. |
Error: PR already merged! |
|
Sorry for another pr on this. I thought the failure from msvc cuda, which is now always failed.
To avoid setting the lib path in msvc, gko makes all test works in the library path (dll location).
I changed the working directory to access testing file in #1607 However, it can not find the dll path now.
follow the
matrices/config.hpp.in
to pass the file path