-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #115
V2 #115
Conversation
# Conflicts: # src/api/resources/document/client/Client.ts # src/api/resources/graph/client/Client.ts # src/api/resources/graph/resources/edge/client/Client.ts # src/api/resources/graph/resources/episode/client/Client.ts # src/api/resources/graph/resources/node/client/Client.ts # src/api/resources/group/client/Client.ts # src/api/resources/memory/client/Client.ts # src/api/resources/user/client/Client.ts # src/serialization/types/AddMemoryResponse.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to ec02356 in 1 minute and 49 seconds
More details
- Looked at
1804
lines of code in26
files - Skipped
8
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. src/version.ts:1
- Draft comment:
SDK version update appears deliberate. Ensure the version change to '2.3.0' is intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is related to a dependency version change, which is not allowed according to the rules. The comment asks the author to ensure the version change is intended, which is also not allowed.
2. src/api/types/index.ts:1
- Draft comment:
UserNodeResponse type inclusion looks correct. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
3. src/serialization/types/UserNodeResponse.ts:5
- Draft comment:
The schema for UserNodeResponse appears consistent with EntityNode. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_27y7DhxejMy7KnUK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 054538a in 1 minute and 45 seconds
More details
- Looked at
37
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. examples/graph/user_graph_example.ts:157
- Draft comment:
Consider handling the case whereclient.user.getNode
returns null. Currently, no feedback is provided ifuserNode
is absent. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. examples/graph/user_graph_example.ts:171
- Draft comment:
Add a newline at the end of the file to adhere to common style guidelines. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
While having a newline at the end of file is a common convention, this kind of minor style issue should typically be handled by automated tooling like linters or formatters. The comment doesn't point out a significant issue that requires human attention. Additionally, this isn't related to any logical changes in the diff - it's a pre-existing style issue.
The missing newline could cause issues with some tools and is considered a best practice in many style guides. Some would argue it's worth fixing.
While true, this is exactly the kind of issue that should be caught and fixed automatically by development tools rather than requiring manual review comments.
Delete this comment as it points out a minor style issue that should be handled by automated tooling rather than manual review.
3. package.json:3
- Draft comment:
Version bump noted. Ensure related documentation reflects these changes if applicable. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
4. examples/graph/user_graph_example.ts:157
- Draft comment:
Good example addition. Consider adding a brief inline comment explaining the 'reranker: "node_distance"' parameter for clarity. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
This is an example file demonstrating API usage. While the reranker parameter might not be immediately obvious, adding inline comments for every parameter would make the example more cluttered. The purpose of example code is to show how to use the API, and the parameter name "node_distance" is relatively self-explanatory. Documentation about what rerankers are available should live in the API docs, not in example code.
The comment could help newcomers understand what the reranker parameter does at a glance. Example code is often the first place developers look for guidance.
While documentation is valuable, example code should be clean and focused on demonstrating usage patterns. Inline comments for every parameter would reduce readability and maintainability.
Delete the comment as it suggests adding unnecessary documentation to example code. The parameter name is clear enough, and detailed documentation belongs in API docs.
5. package.json:3
- Draft comment:
Version bump to 2.4.0; please ensure associated changelog/documentation updates. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is related to a version bump, which falls under the rule of not commenting on pure dependency changes. Additionally, it asks the author to ensure documentation updates, which is not allowed.
Workflow ID: wflow_DRwBxTbj2OTN0pB2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add
getNode()
inUser
anddelete()
inEpisode
, removevercel_ai
example, and update SDK version to2.3.0
.getNode()
method inUser
class to retrieve user nodes.delete()
method inEpisode
class to delete episodes by UUID.vercel_ai
example directory, including.gitignore
,README.md
,eslint.config.mjs
,next.config.ts
,package.json
,postcss.config.mjs
,scripts/seed_zep.ts
, andsrc/app
directory.2.3.0
inversion.ts
andClient.ts
files across multiple resources.getNode()
inreference.md
.UserNodeResponse
serialization inUserNodeResponse.ts
and updateindex.ts
inserialization/types
andapi/types
.This description was created by
for 054538a. It will automatically update as commits are pushed.