-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(jest): Use jest-circus
and instrument jest tests
#22237
Merged
billyvg
merged 8 commits into
getsentry:master
from
billyvg:build/jest/add-perf-timings
Nov 30, 2020
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
29c8a80
fix merge base
billyvg 6939166
Revert "fix merge base"
billyvg 348278d
chore(jest): Upgrade to jest 26.5.0
billyvg b90d6ac
rename env
billyvg 986b283
cleanup
billyvg e8075b2
remove console.log
billyvg 7404387
fix jest circus pin
billyvg 28f673c
undo yarn lockfile changes
billyvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,258 @@ | ||
/* eslint-env node */ | ||
const process = require('process'); // eslint-disable-line import/no-nodejs-modules | ||
|
||
// TODO: Make this configurable | ||
const JsDomEnvironment = require('@visual-snapshot/jest-environment'); | ||
|
||
const Sentry = require('@sentry/node'); | ||
require('@sentry/tracing'); | ||
|
||
function isNotTransaction(span) { | ||
return span.op !== 'jest test'; | ||
} | ||
|
||
class SentryEnvironment extends JsDomEnvironment { | ||
constructor(config, context) { | ||
super(config, context); | ||
|
||
if (!config.testEnvironmentOptions || !config.testEnvironmentOptions.SENTRY_DSN) { | ||
return; | ||
} | ||
|
||
this.Sentry = Sentry; | ||
this.Sentry.init({ | ||
dsn: config.testEnvironmentOptions.SENTRY_DSN, | ||
tracesSampleRate: 1.0, | ||
environment: !!process.env.CI ? 'ci' : 'local', | ||
}); | ||
this.testPath = context.testPath.replace(process.cwd(), ''); | ||
|
||
this.runDescribe = new Map(); | ||
this.testContainers = new Map(); | ||
this.tests = new Map(); | ||
this.hooks = new Map(); | ||
} | ||
|
||
async setup() { | ||
if (!this.Sentry) { | ||
await super.setup(); | ||
return; | ||
} | ||
|
||
this.transaction = Sentry.startTransaction({ | ||
op: 'jest test suite', | ||
description: this.testPath, | ||
name: this.testPath, | ||
}); | ||
|
||
Sentry.configureScope(scope => scope.setSpan(this.transaction)); | ||
|
||
const span = this.transaction.startChild({ | ||
op: 'setup', | ||
description: this.testPath, | ||
}); | ||
await super.setup(); | ||
span.finish(); | ||
} | ||
|
||
async teardown() { | ||
if (!this.Sentry) { | ||
await super.teardown(); | ||
return; | ||
} | ||
|
||
const span = this.transaction.startChild({ | ||
op: 'teardown', | ||
description: this.testPath, | ||
}); | ||
await super.teardown(); | ||
span.finish(); | ||
|
||
if (this.transaction) { | ||
this.transaction.finish(); | ||
} | ||
|
||
this.runDescribe = null; | ||
this.testContainers = null; | ||
this.tests = null; | ||
this.hooks = null; | ||
this.hub = null; | ||
this.Sentry = null; | ||
} | ||
|
||
runScript(script) { | ||
// We are intentionally not instrumenting this as it will produce hundreds of spans. | ||
return super.runScript(script); | ||
} | ||
|
||
getName(parent) { | ||
if (!parent) { | ||
return ''; | ||
} | ||
|
||
// Ignore these for now as it adds a level of nesting and I'm not quite sure where it's even coming from | ||
if (parent.name === 'ROOT_DESCRIBE_BLOCK') { | ||
return ''; | ||
} | ||
|
||
const parentName = this.getName(parent.parent); | ||
return `${parentName ? `${parentName} >` : ''} ${parent.name}`; | ||
} | ||
|
||
getData({name, ...event}) { | ||
switch (name) { | ||
case 'run_describe_start': | ||
case 'run_describe_finish': | ||
return { | ||
op: 'describe', | ||
obj: event.describeBlock, | ||
parentObj: event.describeBlock.parent, | ||
dataStore: this.runDescribe, | ||
parentStore: this.runDescribe, | ||
}; | ||
|
||
case 'test_start': | ||
case 'test_done': | ||
return { | ||
op: 'test', | ||
obj: event.test, | ||
parentObj: event.test.parent, | ||
dataStore: this.testContainers, | ||
parentStore: this.runDescribe, | ||
beforeFinish: span => { | ||
span.setStatus(!event.test.errors.length ? 'ok' : 'unknown_error'); | ||
return span; | ||
}, | ||
}; | ||
|
||
case 'test_fn_start': | ||
case 'test_fn_success': | ||
case 'test_fn_failure': | ||
return { | ||
op: 'test-fn', | ||
obj: event.test, | ||
parentObj: event.test, | ||
dataStore: this.tests, | ||
parentStore: this.testContainers, | ||
beforeFinish: span => { | ||
span.setStatus(!event.test.errors.length ? 'ok' : 'unknown_error'); | ||
return span; | ||
}, | ||
}; | ||
|
||
case 'hook_start': | ||
return { | ||
obj: event.hook.parent, | ||
op: event.hook.type, | ||
dataStore: this.hooks, | ||
}; | ||
|
||
case 'hook_success': | ||
case 'hook_failure': | ||
return { | ||
obj: event.hook.parent, | ||
parentObj: event.test && event.test.parent, | ||
dataStore: this.hooks, | ||
parentStore: this.testContainers, | ||
beforeFinish: span => { | ||
const parent = this.testContainers.get(this.getName(event.test)); | ||
if (parent && !Array.isArray(parent)) { | ||
return parent.child(span); | ||
} else if (Array.isArray(parent)) { | ||
return parent.find(isNotTransaction).child(span); | ||
} | ||
return span; | ||
}, | ||
}; | ||
|
||
case 'start_describe_definition': | ||
case 'finish_describe_definition': | ||
case 'add_test': | ||
case 'add_hook': | ||
case 'run_start': | ||
case 'run_finish': | ||
case 'test_todo': | ||
case 'setup': | ||
case 'teardown': | ||
return null; | ||
|
||
default: | ||
return null; | ||
} | ||
} | ||
|
||
handleTestEvent(event) { | ||
if (!this.Sentry) { | ||
return; | ||
} | ||
|
||
const data = this.getData(event); | ||
const {name} = event; | ||
|
||
if (!data) { | ||
return; | ||
} | ||
|
||
const {obj, parentObj, dataStore, parentStore, op, description, beforeFinish} = data; | ||
|
||
const testName = this.getName(obj); | ||
|
||
if (name.includes('start')) { | ||
// Make this an option maybe | ||
if (!testName) { | ||
return; | ||
} | ||
|
||
const spans = []; | ||
const parentName = parentObj && this.getName(parentObj); | ||
const spanProps = {op, description: description || testName}; | ||
const span = | ||
parentObj && parentStore.has(parentName) | ||
? Array.isArray(parentStore.get(parentName)) | ||
? parentStore | ||
.get(parentName) | ||
.map(s => | ||
typeof s.child === 'function' | ||
? s.child(spanProps) | ||
: s.startChild(spanProps) | ||
) | ||
: [parentStore.get(parentName).child(spanProps)] | ||
: [this.transaction.startChild(spanProps)]; | ||
|
||
spans.push(...span); | ||
|
||
// If we are starting a test, let's also make it a transaction so we can see our slowest tests | ||
if (spanProps.op === 'test') { | ||
spans.push( | ||
Sentry.startTransaction({ | ||
...spanProps, | ||
op: 'jest test', | ||
name: spanProps.description, | ||
description: null, | ||
}) | ||
); | ||
} | ||
|
||
dataStore.set(testName, spans); | ||
|
||
return; | ||
} | ||
|
||
if (dataStore.has(testName)) { | ||
const spans = dataStore.get(testName); | ||
|
||
spans.forEach(span => { | ||
if (beforeFinish) { | ||
span = beforeFinish(span); | ||
if (!span) { | ||
throw new Error('`beforeFinish()` needs to return a span'); | ||
} | ||
} | ||
|
||
span.finish(); | ||
}); | ||
} | ||
} | ||
} | ||
|
||
module.exports = SentryEnvironment; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HazAT This might be interesting to do as an independent package.