Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): Ignore 300-400 status codes on app errors in Nuxt #15473

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix(nuxt): Ignore 300-400 status codes on app errors in Nuxt #15473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7745aa8
fix(nuxt): ignore 300-400 status codes on app errors in Nuxt
GerryWilko Feb 24, 2025
26c4471
clean up comment
GerryWilko Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/nuxt/src/runtime/plugins/sentry.client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { GLOBAL_OBJ, getClient } from '@sentry/core';
import { browserTracingIntegration, vueIntegration } from '@sentry/vue';
import { defineNuxtPlugin } from 'nuxt/app';
import { defineNuxtPlugin, isNuxtError } from 'nuxt/app';
import type { GlobalObjWithIntegrationOptions } from '../../client/vueIntegration';
import { reportNuxtError } from '../utils';

Expand Down Expand Up @@ -66,6 +66,12 @@ export default defineNuxtPlugin({
});

nuxtApp.hook('app:error', error => {
if (isNuxtError(error)) {
// Do not report if status code is 3xx or 4xx
if (error.statusCode >= 300 && error.statusCode < 500) {
Comment on lines +69 to +71
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 conditions could be ANDed.

return;
}
}
reportNuxtError({ error });
});

Expand Down
Loading