Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sveltekit)!: Remove fetchProxyScriptNonce option #15123

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat(sveltekit)!: Remove fetchProxyScriptNonce option #15123

merged 2 commits into from
Jan 22, 2025
+19 −36

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 22, 2025 •
edited
Loading

This PR removes the fetchProxyScriptNonce and in turn simplifies our transformPageChunk callback a bit.

In a follow-up, I'll address #15007

@Lms24 Lms24 self-assigned this Jan 22, 2025
@Lms24 Lms24 requested review from mydea and lforst January 22, 2025 09:00
lforst
lforst approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything needed in the migration guide?

@Lms24
Copy link
Member Author

Lms24 commented Jan 22, 2025 •
edited
Loading

thanks, great catch! added an entry in 96bd118

@Lms24 Lms24 mentioned this pull request Jan 22, 2025
Closed
@Lms24 Lms24 merged commit 94e7347 into develop Jan 22, 2025
146 checks passed
@Lms24 Lms24 deleted the lms/feat-sveltekit-remove-fetch-proxy-nonce branch January 22, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @lforst