Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix)!: Remove autoInstrumentRemix option #15074

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 20, 2025

Resolves #14312

Copy link

codecov bot commented Jan 20, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
247 1 246 12
View the top 1 failed tests by shortest run time
server-transactions.test.ts Sends parameterized transaction name to Sentry
Stack Traces | 0.143s run time
server-transactions.test.ts:8:1 Sends parameterized transaction name to Sentry

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@lforst
Copy link
Member Author

lforst commented Jan 21, 2025

@onurtemizkan I am a bit lost as to why the integration tests are failing. Would you mind taking a look?

@onurtemizkan
Copy link
Collaborator

@lforst - Sure, checking now 👍

@onurtemizkan
Copy link
Collaborator

@lforst - looks like error handling was also removed with the tracing. I added it back. de3fe46

@lforst
Copy link
Member Author

lforst commented Jan 21, 2025

Oh damn, totally missed that. Thank you so much!

@lforst lforst marked this pull request as ready for review January 21, 2025 16:40
Copy link
Collaborator

@onurtemizkan onurtemizkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lforst lforst merged commit c307597 into develop Jan 21, 2025
150 checks passed
@lforst lforst deleted the lforst-rm-autoinstrremix branch January 21, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9] Unify instrumentation for Remix (removing autoInstrumentRemix)
2 participants