fix(node/nestjs): Use method on current fastify request #15066
Merged
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhiggins
changed the title
chargome
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Hey @tjhiggins, thanks for the fix and the added test! The changes make sense to me, could you just format the files so our CI is happy?
|
@chargome should be good now |
|
@chargome we should also backport this to v8 I guess! |
chargome
changed the title
chargome
approved these changes
Jan 21, 2025
chargome
added a commit
that referenced
this pull request
Jan 21, 2025
The previous code was using fastify `request.routeOptions.method` which is all methods the current route supports - not the current request method. Ex. `@All()` nestjs decorator `request.routeOptions.method = ['GET', 'POST', 'HEAD', ...]` - Added a test for `@All()` - Updated instances of fastify request to use `request.method` which matches express --------- Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
mydea
added a commit
that referenced
this pull request
Jan 21, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15066 --------- Co-authored-by: chargome <20254395+chargome@users.noreply.github.com> Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
chargome
added a commit
that referenced
this pull request
Jan 21, 2025
Backports #15066 --------- Co-authored-by: tjhiggins <thomashiggins10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was using fastify
request.routeOptions.methodwhich is all methods the current route supports - not the current request method.Ex.
@All()nestjs decoratorrequest.routeOptions.method = ['GET', 'POST', 'HEAD', ...]@All()request.methodwhich matches express