Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(inquirer): Replace inquirer with prompts #217

Merged
merged 4 commits into from
May 4, 2021
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented May 4, 2021

Inspired by facebook/create-react-app#10083. prompts is a modern and
lighter alternative to inquirer and it is almost a drop-in
replacement. This change shaves off 0.7MB from our minified builds.

Inspired by facebook/create-react-app#10083. `prompts` is a modern and
lighter alternative to `inquirer` and it is almost a drop-in
replacement. This change shaves off 0.7MB from our minified builds.
@BYK BYK requested review from chadwhitacre, jan-auer and tonyo May 4, 2021 15:25
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but seems reasonable.

@BYK BYK closed this May 4, 2021
@BYK BYK reopened this May 4, 2021
@BYK BYK merged commit 1f661f6 into master May 4, 2021
@BYK BYK deleted the byk/ref/inquirer-prompt branch May 4, 2021 17:48
BYK added a commit that referenced this pull request May 5, 2021
* ref(inquirer): Replace inquirer with prompts

Inspired by facebook/create-react-app#10083. `prompts` is a modern and
lighter alternative to `inquirer` and it is almost a drop-in
replacement. This change shaves off 0.7MB from our minified builds.

* ref: Lint fixes

* add @types/prompts

* remove obsolete function

Co-authored-by: getsentry-bot <bot@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants