Fix disappearing writer content #6972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbora
previously approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Works perfect for me🎉 It would be nice if @distantnative take a look.
distantnative
previously approved these changes
Feb 4, 2025
bastianallgeier
dismissed stale reviews from distantnative and afbora
The base branch was changed.
|
Yikes. I think we need to recreate the branch and cherry pick the relevant commits. Otherwise we will get 4.7.0 stuff in it as well. |
bastianallgeier
force-pushed
the
fix/vanishing-change
branch
from
04c3bc7 to
e5548c9
Compare
|
Ok, I've fixed it. Could you have another look at it? I think it's all fine. But better be safe. |
afbora
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fixes
For review team