Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageTree controller class #6709

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Sep 28, 2024

Description

Summary of changes

  • Moved page tree request logic from area config to PageTree Panel controller clas
  • Added unit tests

Reasoning

Make more code testable.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

@distantnative distantnative self-assigned this Sep 28, 2024
@distantnative distantnative force-pushed the v5/refactor/page-tree-controller-class branch 2 times, most recently from a5b7d3e to c8e5c8d Compare September 28, 2024 09:57
@distantnative distantnative marked this pull request as ready for review September 28, 2024 10:00
@distantnative distantnative requested review from afbora and a team September 28, 2024 11:07
@afbora
Copy link
Member

afbora commented Sep 29, 2024

@distantnative I couldn't test moving the page for this branch or v5 (disabled all parents). Works great for v4. Could you able to move any page with this branch?

@distantnative distantnative marked this pull request as draft September 29, 2024 17:24
@distantnative distantnative force-pushed the v5/refactor/page-tree-controller-class branch 2 times, most recently from 0b11dff to 577f0f8 Compare October 7, 2024 15:58
@distantnative
Copy link
Member Author

@afbora does it work now for you?

@distantnative distantnative marked this pull request as ready for review October 7, 2024 16:01
@distantnative distantnative force-pushed the v5/refactor/page-tree-controller-class branch from 577f0f8 to 20d1a3a Compare October 7, 2024 16:08
@afbora
Copy link
Member

afbora commented Oct 8, 2024

@distantnative Still broken for me. Now I can move any page to any target. This is not correct behavior.

@distantnative
Copy link
Member Author

@afbora what's your test case where the result of this PR is different to develop-minor?

Mine is using the starter kit and creating a test note page on the top-level. That note page I can move in the same pages on this branch as on develop-minor with certain pages disabled:

develop-minor:
Screenshot 2024-10-08 at 2 56 54 PM

This PR:
Screenshot 2024-10-08 at 2 55 41 PM

@afbora
Copy link
Member

afbora commented Oct 8, 2024

I was tested for starterkit with v5/refactor/page-tree-controller-class branch.
v5-develop test_panel_site

Something wrong. I've tested on 4.4.1 for Exploring the universe page. It should be like that as default.
4 4 1 test_panel_site

@distantnative
Copy link
Member Author

Oh interesting, this seems to be rather a difference main vs. develop-minor branch. Not this PR. I wonder why.

@distantnative
Copy link
Member Author

@afbora I think it's because of #6717

@bastianallgeier
Copy link
Member

@distantnative haha, I posted the exact same comment basically 4 seconds after yours :)

@distantnative distantnative force-pushed the v5/refactor/page-tree-controller-class branch from 20d1a3a to 8799154 Compare October 9, 2024 10:06
@distantnative distantnative added the needs: delay ⏳️ Requires more time, on hold label Oct 9, 2024
@distantnative distantnative force-pushed the v5/refactor/page-tree-controller-class branch from 8799154 to 23f8130 Compare October 9, 2024 14:48
@distantnative distantnative removed the needs: delay ⏳️ Requires more time, on hold label Oct 9, 2024
@bastianallgeier
Copy link
Member

Is the failing unit test a false positive?

@distantnative
Copy link
Member Author

They were still set up for the no pages section needed state.

Fixed them and added more specific ones too.

@bastianallgeier bastianallgeier merged commit df33dea into v5/develop Oct 11, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/refactor/page-tree-controller-class branch October 11, 2024 07:51
@bastianallgeier bastianallgeier added this to the 5.0.0-alpha.4 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants