-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageTree
controller class
#6709
PageTree
controller class
#6709
Conversation
a5b7d3e
to
c8e5c8d
Compare
@distantnative I couldn't test moving the page for this branch or v5 (disabled all parents). Works great for v4. Could you able to move any page with this branch? |
0b11dff
to
577f0f8
Compare
@afbora does it work now for you? |
577f0f8
to
20d1a3a
Compare
@distantnative Still broken for me. Now I can move any page to any target. This is not correct behavior. |
@afbora what's your test case where the result of this PR is different to Mine is using the starter kit and creating a test |
Oh interesting, this seems to be rather a difference |
@distantnative haha, I posted the exact same comment basically 4 seconds after yours :) |
20d1a3a
to
8799154
Compare
8799154
to
23f8130
Compare
Is the failing unit test a false positive? |
They were still set up for the Fixed them and added more specific ones too. |
Description
Summary of changes
PageTree
Panel controller clasReasoning
Make more code testable.
Ready?