-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.70, 1.71 to CI, bump MSRV to 1.65 #1067
Conversation
Oh, 1.65 also includes generic associated types (GATs). #908 👀 |
We should also bump |
9655ad7
to
f84efdf
Compare
Good catch! Done. |
f84efdf
to
3b51122
Compare
There's also
|
3b51122
to
c29ab3d
Compare
Heads-up: I'm gonna try the rebase button 😄. |
c29ab3d
to
ba19c77
Compare
Not sure what's up with the failing tests. |
I'm not sure what's going on with the proj build. These lines are suspicious:
I think that rust-1.72 is the first release on the new debian "bookworm" distro. Not sure if that's relevant. It did force me to change the libtiff dependency to something that would (I hoped) work across releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once tests pass ✅
Fixed with georust/docker-images@112764c I'm not sure what's wrong with our setup vs. debian-bookworm, but I'm happy to kick that can down the road. |
CHANGES.md
if knowledge of this change could be valuable to users.1.65 was released more than 10 months ago: https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html
Notably (for me anyway because I keep trying to use it) this means we can use let/else syntax.
As a reminder, our policy has been to support at least the last 6 months (STABLE + 3 prior), but I usually bump it conservatively to whatever feature is causing annoyance.