ui improvements to review listings #1734
Open
+87
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PE39806
approved these changes
Jan 22, 2025
ARADDCC012
requested changes
Jan 22, 2025
| @@ -40,6 +41,7 @@ export default function AccessRequestReview() { | |||
| return setErrorMessage('Could not find access request ID') | |||
| } | |||
|
|
|||
| setIsReviewButtonLoading(false) | |||
There was a problem hiding this comment.
Should this be setIsReviewButtonLoading(true)?
| setAcceptedReviewResponses(updatedApprovals) | ||
| setChangesRequestedReviewResponses(updatedRequests) | ||
| }, [reviewResponses]) | ||
| const orderedReviewResponses = useMemo(() => reviewResponses.sort(sortByCreatedAtDescending) || [], [reviewResponses]) |
There was a problem hiding this comment.
As .sort() mutates the existing array, I'd suggest using reviewResponses.toSorted(sortByCreatedAtDescending). This works the same as .sort() but leaves the original array untouched which will avoid any unwanted behaviour in parent components.
There was a problem hiding this comment.
Didn't know about toSorted interesting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.