Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructured the model mirror page and added a backend check for exis… #1691

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

ARADDCC002
Copy link
Member

…ting model card before allowing export

@@ -191,7 +191,7 @@ module.exports = {
enabled: false,
},
export: {
enabled: false,
enabled: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required?

</Container>
<>
<Typography variant='h6' component='h1' color='primary' align='center'>
Model Export Agreement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's super clear that this section of the page doesn't just contain the agreement but also the ability to actually kick off an export. Users will be looking for how they export a model, rather than where the agreement is. The agreement is just something they need to do before being able to do the actual thing they want which is exporting a model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why you've moved this to top of the page and and not hidden it by default but I'm not sure whether this will cause confusion with users thinking they need to re-populate this every time they export a model? It still doesn't feel quite right to me how we've combined the model setting required to export a model and the ability to actually do the model export.

@ARADDCC002 ARADDCC002 merged commit d8f045c into main Jan 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants