Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a temporary fix for spacing alignment of av chips #1682

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

ARADDCC002
Copy link
Member

No description provided.

PE39806
PE39806 previously approved these changes Dec 13, 2024
@PE39806 PE39806 self-requested a review December 13, 2024 09:23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what has changed, but in both releases and release views long file names are no longer truncated and cause the avscanners to disappear
image
image

Copy link
Contributor

@PE39806 PE39806 Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now fixed for >600px width windows, but for windows that are <=600px the name overflows for both reviews and review pages. Ideally, we should fix this but I am aware that not many of our end users are expected to use such a narrow display format.
image

@PE39806 PE39806 dismissed their stale review December 13, 2024 09:26

re-review required

@ARADDCC002 ARADDCC002 merged commit 4762935 into main Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants