kernel: make MarkAllSubBagsDefault private, use in Julia GC #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
rbehrends
approved these changes
Jan 10, 2020
MarkAllSubBagsDefault is an implementation detail of GASMAN (and now also Julia GC), and should not be used by client code ever. As such, it seems sensible to hide its implementation. Also update/remove/add some comments.
fingolfin
force-pushed
the
mh/MarkAllSubBagsDefault
branch
from
6dc3e17 to
3336c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarkAllSubBagsDefault is an implementation detail of GASMAN (and
now also Julia GC), and should not be used by client code ever. As such,
it seems sensible to hide its implementation.
Also update/remove/add some comments.
This PR conflicts with PR #3840, but resolving the clash should be trivial. I'll happily do it for this PR if PR #3840 gets merged first.