-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tests for permutations #1145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
+ Coverage 59.58% 59.95% +0.37%
==========================================
Files 934 933 -1
Lines 292154 290265 -1889
Branches 18148 17611 -537
==========================================
- Hits 174072 174032 -40
+ Misses 113713 111868 -1845
+ Partials 4369 4365 -4
Continue to review full report at Codecov.
|
ab4aab1
to
b2cf3e9
Compare
fwiw |
Excellent -- I didn't check before writing that remark (I actually only thought of it when writing th PR description, should have checked). Anyway, I actually see |
#1130 takes it to literally 99% though (and I only know this because we had the discussion about test coverage today ;)) |
This PR begins adding additional tests for permutations, working systematically through
src/permutat.c
.We might want to add similar tests for partial permutations and transformations, but I know little about them.