Don't use undocumented InstallGlobalFunction argument #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not just undocumented, it is also not used, and never was.
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 99.52% 99.52% -0.01%
==========================================
Files 94 94
Lines 106313 106312 -1
==========================================
- Hits 105806 105805 -1
Misses 507 507
|
olexandr-konovalov
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Thanks. @vendramin please indicate that you have seen this - using an emoji reaction, or a comment, or a proper review of the PR, or by actually merging this (I suggest to use "rebase and merge" to keep the history linear).
|
@vendramin I would like to merge this before the new release - have you seen this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not just undocumented, it is also not used, and never was.
This code will otherwise produce a warning in GAP 4.12, see gap-system/gap#3694