Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: small stableswap refactor and docs update #751

Merged
merged 23 commits into from
Jan 31, 2024
Merged

refactor: small stableswap refactor and docs update #751

merged 23 commits into from
Jan 31, 2024

Conversation

enthusiastmartin
Copy link
Contributor

This PR refactors stableswap pallet little bit - code duplication and consistent naming.

Also updates code docs and comments.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Crate versions that have been updated:

  • runtime-integration-tests: v1.17.1 -> v1.17.2
  • hydra-dx-math: v7.7.2 -> v7.8.0
  • pallet-stableswap: v3.4.2 -> v3.4.3
  • hydradx-runtime: v205.0.0 -> v206.0.0

Runtime version has been increased.

Roznovjak
Roznovjak reviewed Jan 30, 2024
View reviewed changes
pallets/stableswap/README.md Outdated Show resolved Hide resolved
pallets/stableswap/src/lib.rs Show resolved Hide resolved
@mrq1911 mrq1911 changed the title feat: small stableswap refactor and docs update refactor: small stableswap refactor and docs update Jan 30, 2024
mrq1911
mrq1911 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix reserves and LGTM

math/src/stableswap/math.rs Show resolved Hide resolved
enthusiastmartin and others added 12 commits January 31, 2024 12:41
@enthusiastmartin @Roznovjak
Update pallets/stableswap/README.md
3c88bbc 
Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>
@enthusiastmartin
feat: update omnipool code docs and comments
f525900
@enthusiastmartin
add on trade fee comment
f3d37e5
@enthusiastmartin @Roznovjak
Update pallets/omnipool/README.md
6941ddc 
Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>
@enthusiastmartin @Roznovjak
Update pallets/omnipool/src/lib.rs
b30aea7 
Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>
@enthusiastmartin @Roznovjak
Update pallets/omnipool/README.md
1ce9e13 
Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>
@enthusiastmartin @Roznovjak
Update pallets/omnipool/src/lib.rs
96a20c8 
Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>
@enthusiastmartin @Roznovjak
Update pallets/omnipool/src/lib.rs
8ccc104 
Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>
@enthusiastmartin
add additional tests
e2b162c
@enthusiastmartin
adjust rounding
9421853
@enthusiastmartin
update repo readme
9f6e4dd
@vgantchev
add docs to readme
86f38d1
@enthusiastmartin enthusiastmartin merged commit d35ad7d into master Jan 31, 2024
4 checks passed
@enthusiastmartin enthusiastmartin deleted the feat/stableswap-refactor branch January 31, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roznovjak Roznovjak Roznovjak left review comments

@mrq1911 mrq1911 mrq1911 approved these changes

@vgantchev vgantchev vgantchev approved these changes

@dmoka dmoka Awaiting requested review from dmoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enthusiastmartin @vgantchev @mrq1911 @Roznovjak